Antoni Segura Puimedon has posted comments on this change.
Change subject: HostStats: stop storing list of host ifids and speeds
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/29470/1/vdsm/virt/sampling.py
File vdsm/virt/sampling.py:
Line 100: return '0'
Line 101: return 'up' if flags & ethtool.IFF_RUNNING else
'down'
Line 102:
Line 103: @staticmethod
Line 104: def _getLinkSpeed(dev):
no good reason. whatever you prefer.
I vote for module private
as well.
Line 105: if dev.isNIC():
Line 106: speed = netinfo.nicSpeed(dev.name)
Line 107: elif dev.isBOND():
Line 108: speed = netinfo.bondSpeed(dev.name)
--
To view, visit
http://gerrit.ovirt.org/29470
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad0605c910564a8a7072484301c51b4b8a325751
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes