Dan Kenigsberg has posted comments on this change.
Change subject: BZ#770834 - Handle correctly nic names like p33p1
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/configNetwork.py
Line 157: return sorted(nics, key=splitNicForSorting)
we should be just like initscripts' sort. If they have a bug, please open a BZ# on
them. I do not think that the "correctness" of the sort is important. I care
only about consistency with initscripts - so until they fix the BZ you are going to open,
we need to be conform to their sort function.
--
To view, visit
http://gerrit.ovirt.org/799
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I716f5d7d137325abaa0022a40f482c9ad270855a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>