Dan Kenigsberg has posted comments on this change.
Change subject: virt: graphdev: add the GraphicsDevice class
......................................................................
Patch Set 23: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/26895/23/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 4922: if port:
Line 4923: dev['port'] = port
Line 4924: port = gxml.getAttribute('tlsPort')
Line 4925: if port:
Line 4926: dev['tlsPort'] = port
_getUnderlyingDisplayPort used to update self.conf['displayPort']. This should be
maintained for backward compatibility.
Line 4927:
Line 4928: def _getUnderlyingNetworkInterfaceInfo(self):
Line 4929: """
Line 4930: Obtain network interface info from libvirt.
--
To view, visit
http://gerrit.ovirt.org/26895
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I82e4414aa3efe7c756ba8ef9b7b47e591613a717
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes