Dan Kenigsberg has posted comments on this change.
Change subject: BZ#733669 Improve error reporting for wrong local hostname
......................................................................
Patch Set 5: (1 inline comment)
....................................................
File vds_bootstrap/vds_bootstrap.py
Line 608:
you are going to kill me for not thinking of this before...
but bootstrap code is so fragile and broken, that if ANYTHING here raises an exception, it
would not be caught at reported to rhevm. is there any chance we'll see an exception
here? if so, we'd better wrap this in try-except like everywhere else in this y*cky
file.
--
To view, visit
http://gerrit.usersys.redhat.com/924
To unsubscribe, visit
http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf0ae2d62772b01d05d9d5e62d2433c1758d69b1
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>