Dan Kenigsberg has posted comments on this change.
Change subject: netinfo: remove code duplication between nics, bridges, bonds and vlans
......................................................................
Patch Set 4: Code-Review-1
(2 comments)
Nice! (one little comment, though)
http://gerrit.ovirt.org/#/c/24174/4/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:
Line 34: import ethtool
Line 35:
Line 36: from .config import config
Line 37: from . import constants
Line 38: from .ipwrapper import DUMMY_BRIDGE, getLink, getLinks, Link
DUMMY_BRIDGE is unrelated to the other three, indulge it with its own import line.
Line 39: from .ipwrapper import IPRoute2Error
Line 40: from .ipwrapper import Route
Line 41: from .ipwrapper import routeGet
Line 42: from .ipwrapper import routeShowGateways, routeShowAllDefaultGateways
Line 77:
Line 78: _Qos = namedtuple('Qos', 'inbound outbound')
Line 79:
Line 80: OPERSTATE_UP = 'up'
Line 81: DUMMY_BRIDGE # Appease flake8 since dummy bridge should be exported from here
The toil one must take to avoid circular imports...
Line 82:
Line 83:
Line 84: def _visible_devs(predicate):
Line 85: """Returns a list of visible (vdsm manageable) links for which
the
--
To view, visit
http://gerrit.ovirt.org/24174
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7c54801822d487bde7f0e4ba9e79bf278e2a7598
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes