Change in vdsm[master]: pylint: hostdevTests: differentiate device object and device...

[Code Review]

From Dan Kenigsberg <danken(a)redhat.com&gt;:

Dan Kenigsberg has uploaded a new change for review.

Change subject: pylint: hostdevTests: differentiate device object and device_name
......................................................................

pylint: hostdevTests: differentiate device object and device_name

Change-Id: I37f87d020806c003b35dfa570907f826b7ca14dc
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com&gt;
---
M tests/hostdevTests.py
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/42/69342/1

diff --git a/tests/hostdevTests.py b/tests/hostdevTests.py
index 53ff1c6..86ecd40 100644
--- a/tests/hostdevTests.py
+++ b/tests/hostdevTests.py
@@ -526,15 +526,15 @@
             'smp': '8', 'maxVCpus': '160',
             'memSize': '1024', 'memGuaranteedSize':
'512'}
 
-    @permutations([[device] for device in _PCI_DEVICES + _USB_DEVICES +
-                   [_SCSI_DEVICES[2]]])
+    @permutations([[device_name] for device_name in _PCI_DEVICES +
+                   _USB_DEVICES + [_SCSI_DEVICES[2]]])
     def testCreateHostDevice(self, device_name):
         dev_spec = {'type': 'hostdev', 'device': device_name}
         device = hostdevice.HostDevice(self.conf, self.log, **dev_spec)
         self.assertXMLEqual(vmxml.format_xml(device.getXML()),
                             _DEVICE_XML[device_name] % ('',))
 
-    @permutations([[device] for device in _PCI_DEVICES])
+    @permutations([[device_name] for device_name in _PCI_DEVICES])
     def testCreatePCIHostDeviceWithAddress(self, device_name):
         dev_spec = {'type': 'hostdev', 'device': device_name,
'address':
                     self._PCI_ADDRESS}


-- 
To view, visit https://gerrit.ovirt.org/69342
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I37f87d020806c003b35dfa570907f826b7ca14dc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;