Dan Kenigsberg has posted comments on this change.
Change subject: Implement Popen without forking back to python
......................................................................
Patch Set 10: Fails; I would prefer that you didn't submit this
(2 inline comments)
fails `make rpm`
....................................................
File configure.ac
Line 176: PKG_CHECK_MODULES(GTHREAD2, [gthread-2.0])
hey, that's from another patch!
....................................................
File vdsm.spec.in
Line 542: %{_datadir}/%{vdsm_name}/storage/betterPopen/createprocess.so
how about placing it in /usr/lib64/python2.7/site-packages/vdsm/betterPopen ?
after all, it is not really storage-related... nobody wants to be under storage!
--
To view, visit
http://gerrit.ovirt.org/3944
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief4ae42eb57551d7f5893bf562da451a9c98f219
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>