Dan Kenigsberg has posted comments on this change.
Change subject: getDeviceList - passing includePartitioned to HSM
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm_cli/vdsClient.py
Line 545: params = {'includePartitioned': includePartitioned}
* includePartitioned *is* a special option in the api. you are now exposing this fact in
the commandline.
* I'm not sure about the direction of the default. vdsm's default is False, so the
simple choice is to follow suit. However, True is what most human users of vdsClient would
want.
* don't aim to learn code style from vdsClient. Really. Don't.
--
To view, visit
http://gerrit.ovirt.org/4828
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I388442f361ea4ae00e3d8878a2497c7819ab2214
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>