Petr Horáček has posted comments on this change.
Change subject: setupNetworks: doesn't remove broken nw from runningConfig
......................................................................
Patch Set 6: Verified+1
Before the patch, functional tests after:
In [14]: !ip l add dummy_4444 type dummy
In [15]:
conn.setupNetworks({'test-network18':{'nic':'dummy_4444','bridged':False,'bootproto':False,'ipaddr':'240.0.0.1','netmask':'255.255.255.0','gateway':'240.0.0.254'}},{},{'connectivityCheck':False})
Out[15]: {'status': {'code': 0, 'message': 'Done'}}
In [16]: !ip l del dummy_4444
fail with 'EnvironmentError: Failed to restore the persisted networks'
With this change it passes mentioned test (and all network's functional tests except:
testIPv6ConfigNetwork which still fails on my ENV, testSetupNetworkOutboundQos which i
solved in another patch, testRuleExists which used to fail before this patch)
--
To view, visit
http://gerrit.ovirt.org/33995
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c507626705d7ead84db2f3aa15e4032f9558d12
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No