Change in vdsm[master]: core: fixing attribute error on fenceSpmStorage

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: core: fixing attribute error on fenceSpmStorage
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/26358/3/vdsm/storage/spbackends.py
File vdsm/storage/spbackends.py:

Line 337:     def forceFreeSpm(self):
Line 338:         # DO NOT USE, STUPID, HERE ONLY FOR BC
Line 339:         # TODO: SCSI Fence the 'lastOwner'
Line 340:         self.setSpmStatus(LVER_INVALID, SPM_ID_FREE, __securityOverride=True)
Line 341:         self.pool.spmRole = SPM_FREE
>  it returns as part of the status result being checked by the engine
> and was 
We shouldn't need the change you introduced.
Line 342: 
Line 343:     @classmethod
Line 344:     def _getPoolMD(cls, domain):
Line 345:         # This might look disgusting but this makes it so that


-- 
To view, visit http://gerrit.ovirt.org/26358
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5ae4c371e2dc97686621ea16b8cef971183a6ab2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot(a)redhat.com&gt;
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes