Dan Kenigsberg has posted comments on this change.
Change subject: API: streamline and make setLogLevel correct
......................................................................
Patch Set 15: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/38425/15/lib/vdsm/logUtils.py
File lib/vdsm/logUtils.py:
PS15, Line 235: # for backward compatibility
nobody used this verb; let's break compat and accept ONLY string. And I would also be
case insensitive.
This verb should match the current yaml.
https://gerrit.ovirt.org/#/c/38425/15/vdsm/API.py
File vdsm/API.py:
PS15, Line 1380: 'unavail'
'unavail' does not fit here, I'd rather not handle the exception at all.
--
To view, visit
https://gerrit.ovirt.org/38425
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaddbb12d13bdbaa7a02255ab209da11e42d2ea97
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes