Change in vdsm[ovirt-3.5]: volume: Log the correct error when creating a volume fails

[Allon Mureinik]

Allon Mureinik has uploaded a new change for review.

Change subject: volume: Log the correct error when creating a volume fails
......................................................................

volume: Log the correct error when creating a volume fails

When a volume creation failed because of CannotCreateLogicalVolume
exception, we used to lie and log "volume already exists". This log
confused and wasted many developers hours. Now we log the exception
value instead.

Change-Id: I603b055658950dae5ccc3806b8b7a9e53762c5ef
Bug-Url: https://bugzilla.redhat.com/1143830
Relates-To: https://bugzilla.redhat.com/1142710
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com&gt;
Reviewed-on: http://gerrit.ovirt.org/33301
Reviewed-by: Yoav Kleinberger <ykleinbe(a)redhat.com&gt;
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com&gt;
(cherry picked from commit 3e17f9828576f16e4ef95f805c2e7ce27b63d812)
---
M vdsm/storage/volume.py
1 file changed, 1 insertion(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/39/34639/1

diff --git a/vdsm/storage/volume.py b/vdsm/storage/volume.py
index 13bd256..75fa1c4 100644
--- a/vdsm/storage/volume.py
+++ b/vdsm/storage/volume.py
@@ -434,8 +434,7 @@
                                      preallocate, volParent, srcImgUUID,
                                      srcVolUUID, volPath)
             except (se.VolumeAlreadyExists, se.CannotCreateLogicalVolume) as e:
-                cls.log.error("Failed to create volume: %s, volume already "
-                              "exists", volPath)
+                cls.log.error("Failed to create volume %s: %s", volPath, e)
                 vars.task.popRecovery()
                 raise e
             # When the volume format is raw what the guest sees is the apparent


-- 
To view, visit http://gerrit.ovirt.org/34639
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I603b055658950dae5ccc3806b8b7a9e53762c5ef
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;