Ayal Baron has posted comments on this change.
Change subject: Fix getStorageDomainInfo() logic.
......................................................................
Patch Set 3: Code-Review-1
(3 comments)
....................................................
Commit Message
Line 6:
Line 7: Fix getStorageDomainInfo() logic.
Line 8:
Line 9: Domains with 'role' == MASTER_DOMAIN should be attached to a
Line 10: pool at any time.
s/at any time/all the time/ ?
Line 11: Detect 'stale' master domains.
Line 12: Not swallowing errors anymore.
Line 13: Catching specific errors.
Line 14:
Line 8:
Line 9: Domains with 'role' == MASTER_DOMAIN should be attached to a
Line 10: pool at any time.
Line 11: Detect 'stale' master domains.
Line 12: Not swallowing errors anymore.
s/swallowing/hiding/
Line 13: Catching specific errors.
Line 14:
Line 15: Required for making repoStats pool independent.
Line 16:
....................................................
File vdsm/storage/hsm.py
Line 2752: exc_info=True)
Line 2753: else:
Line 2754: # make sure it's THE master of this pool
Line 2755: if pool.masterDomain.sdUUID != sdUUID:
Line 2756: self.log.error("Domain %s is marked as master but
actual "
this is not an error, *at most* it's a warning.
Line 2757: "master is %s",
Line 2758: sdUUID, pool.masterDomain.sdUUID)
Line 2759: else:
Line 2760: poolInfo = pool.getInfo()
--
To view, visit
http://gerrit.ovirt.org/14671
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8b0b2ad3dca19cf203d937c1a9f6a12ab0f1095f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Daniel Paikov <paikov(a)gmail.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes