Change in vdsm[master]: ipwrapper: do not report devices that disappear

Antoni Segura Puimedon has posted comments on this change.

Change subject: ipwrapper: do not report devices that disappear
......................................................................


Patch Set 1: Verified+1

Catches and skips the exception reported in the bug and passes the functional tests:

toniel602 tests (877b8c6) # ./run_tests_local.sh -x functional/networkTests.py           
NetworkTest
    testAddDelBondedNetwork(kwargs=False)                       OK
    testAddDelBondedNetwork(kwargs=True)                        OK
    testAddDelNetwork(kwargs=False)                             OK
    testAddDelNetwork(kwargs=True)                              OK
    testAddNetworkBondWithManyVlans(kwargs=False)               OK
    testAddNetworkBondWithManyVlans(kwargs=True)                OK
    testAddNetworkManyVlans(kwargs=False)                       OK
    testAddNetworkManyVlans(kwargs=True)                        OK
    testAddNetworkVlan(kwargs=False)                            OK
    testAddNetworkVlan(kwargs=True)                             OK
    testAddNetworkVlanBond(kwargs=False)                        OK
    testAddNetworkVlanBond(kwargs=True)                         OK
    testAddVlanedBridgeless                                     OK
    testAddVlanedBridgeless_oneCommand                          OK
    testAfterNetworkSetupHook                                   OK
    testBeforeNetworkSetupHook                                  OK
    testBondHwAddress(kwargs=False)                             OK
    testBondHwAddress(kwargs=True)                              OK
    testBrokenBridgelessNetReplacement                          OK
    testDelNetworkBondAccumulation                              OK
    testDelNetworkWithMTU(kwargs=False)                         OK
    testDelNetworkWithMTU(kwargs=True)                          OK
    testDelWithoutAdd(kwargs=False)                             OK
    testDelWithoutAdd(kwargs=True)                              OK
    testDhclientLeases(kwargs='default')                        OK
    testDhclientLeases(kwargs='local')                          OK
    testEditWithoutAdd(kwargs=False)                            OK
    testEditWithoutAdd(kwargs=True)                             OK
    testFailWithInvalidBondingName(kwargs=False)                OK
    testFailWithInvalidBondingName(kwargs=True)                 OK
    testFailWithInvalidBridgeName                               OK
    testFailWithInvalidIpConfig                                 OK
    testFailWithInvalidNic(kwargs=False)                        OK
    testFailWithInvalidNic(kwargs=True)                         OK
    testFailWithInvalidParams(kwargs=False)                     OK
    testFailWithInvalidParams(kwargs=True)                      OK
    testGetRouteDeviceTo                                        OK
    testHonorBlockingDhcp                                       OK
    testIPv6ConfigNetwork                                       OK
    testIpLinkWrapper                                           OK
    testLegacyBonds                                             OK
    testLowerMtuDoesNotOverride                                 OK
    testNoBridgeLeftovers                                       OK
    testQosNetwork                                              OK
    testReconfigureBrNetWithVanishedPort                        OK
    testRedefineBondedNetworkIPs                                OK
    testRouteExists                                             OK
    testRuleExists                                              OK
    testSafeNetworkConfig(kwargs=False)                         OK
    testSafeNetworkConfig(kwargs=True)                          OK
    testSetupNetworksAddBadParams(bridged=False)                OK
    testSetupNetworksAddBadParams(bridged=True)                 OK
    testSetupNetworksAddBondWithManyVlans(kwargs=False)         OK
    testSetupNetworksAddBondWithManyVlans(kwargs=True)          OK
    testSetupNetworksAddDelBondedNetwork(kwargs=False)          OK
    testSetupNetworksAddDelBondedNetwork(kwargs=True)           OK
    testSetupNetworksAddDelDhcp(kwargs=False)                   OK
    testSetupNetworksAddDelDhcp(kwargs=True)                    OK
    testSetupNetworksAddManyVlans(kwargs=False)                 OK
    testSetupNetworksAddManyVlans(kwargs=True)                  OK
    testSetupNetworksAddNetworkToNicAfterBondBreaking(kwargs=False)OK
    testSetupNetworksAddNetworkToNicAfterBondBreaking(kwargs=True)OK
    testSetupNetworksAddNetworkToNicAfterBondResizing(kwargs=False)OK
    testSetupNetworksAddNetworkToNicAfterBondResizing(kwargs=True)OK
    testSetupNetworksAddOverExistingBond(kwargs=False)          OK
    testSetupNetworksAddOverExistingBond(kwargs=True)           OK
    testSetupNetworksAddVlan(kwargs=False)                      OK
    testSetupNetworksAddVlan(kwargs=True)                       SKIP: This test is known
to break until initscripts-9.03.41-1.el6 is released to fix
https://bugzilla.redhat.com/1086897
    testSetupNetworksConvertVlanNetBridgeness                   OK
    testSetupNetworksDelOneOfBondNets                           OK
    testSetupNetworksKeepNetworkOnBondAfterBondResizing(kwargs=False)OK
    testSetupNetworksKeepNetworkOnBondAfterBondResizing(kwargs=True)OK
    testSetupNetworksMtus(kwargs=False)                         OK
    testSetupNetworksMtus(kwargs=True)                          OK
    testSetupNetworksMultiMTUsOverBond(kwargs=False)            OK
    testSetupNetworksMultiMTUsOverBond(kwargs=True)             OK
    testSetupNetworksMultiMTUsOverNic(kwargs=False)             OK
    testSetupNetworksMultiMTUsOverNic(kwargs=True)              OK
    testSetupNetworksNetCompatibilityBondSingleBridge           OK
    testSetupNetworksNetCompatibilityBondSingleBridgeless       OK
    testSetupNetworksNetCompatibilityNicSingleBridge            OK
    testSetupNetworksNetCompatibilityNicSingleBridgeless        OK
    testSetupNetworksNicless                                    OK
    testSetupNetworksNiclessBridgeless                          OK
    testSetupNetworksOverDhcpIface                              OK
    testSetupNetworksResizeBond(kwargs=False)                   OK
    testSetupNetworksResizeBond(kwargs=True)                    OK
    testSetupNetworksStableBond(kwargs=False)                   OK
    testSetupNetworksStableBond(kwargs=True)                    OK
    testStaticSourceRouting(kwargs=False)                       OK
    testStaticSourceRouting(kwargs=True)                        OK
    testTwiceAdd(kwargs=False)                                  OK
    testTwiceAdd(kwargs=True)                                   OK
    testVolatileConfig(kwargs=False)                            OK
    testVolatileConfig(kwargs=True)                             OK

----------------------------------------------------------------------
Ran 95 tests in 1278.208s

OK (SKIP=1)
toniel602 tests (877b8c6) #

-- 
To view, visit http://gerrit.ovirt.org/29442
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib41336f3ac2f2278db2706f7d4eb3a9b579f66d4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Roman Hodain <roman.hodain(a)gmail.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No