Dan Kenigsberg has posted comments on this change.
Change subject: Sometimes the FD number can be reused in the child process
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File tests/betterPopenTests.py
Line 158: fdpath = "/proc/%d/fd/%d" % (os.getpid(), int(sys.argv[2]))
Line 159: if not os.path.exists(fdpath):
Line 160: print True
Line 161: else:
Line 162: print (open(fdpath).read().strip() == sys.argv[3])
I still do not follow. Why are you reading from fdpath, and why do you expect to find
anything there?
why cannot you check if /proc/$$/fd/ has only 0, 1, and 2?
Line 163:
Line 164: elif cmd == "nofds":
Line 165: try:
Line 166: os.close(int(sys.argv[2]))
--
To view, visit
http://gerrit.ovirt.org/9591
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7044936fba8923297c76d9a2123215ec2b793548
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>