Saggi Mizrahi has posted comments on this change.
Change subject: svdsm: Remove superfluous unlinks
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File vdsm/supervdsm.py
Line 114: def _cleanOldFiles(self):
Line 115: self._log.debug("Cleanning svdsm old files: %s, %s",
Line 116: self.pidfile, self.timestamp, self.address)
Line 117: for f in (self.pidfile, self.timestamps):
Line 118: utils.rmFile(str(f))
The server
Line 119:
Line 120: def _start(self):
Line 121: self._authkey = str(uuid.uuid4())
Line 122: self._log.debug("Launching Super Vdsm")
....................................................
File vdsm/supervdsmServer.py
Line 375:
Line 376: log.debug("Creating PID and TIMESTAMP files: %s, %s",
Line 377: pidfile, timestamp)
Line 378: spid = os.getpid()
Line 379: with open(pidfile, "w") as f:
?
Line 380: f.write(str(spid) + "\n")
Line 381: with open(timestamp, "w") as f:
Line 382: f.write(str(misc.getProcCtime(spid) + "\n"))
Line 383:
--
To view, visit
http://gerrit.ovirt.org/11989
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c3e1968666a34fdfc4b9df8d8c320bcc82c47ca
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server