Change in vdsm[master]: jsonrpc: fd leak

[Piotr Kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: jsonrpc: fd leak
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/45615/3/lib/yajsonrpc/__init__.py
File lib/yajsonrpc/__init__.py:

Line 266:         return self._counter
Line 267: 
Line 268:     @property
Line 269:     def address(self):
Line 270:         return self._addr
>  I think the current code is fine, _addr is ready only, so exposing it
> in a  
Will push a patch to fix the naming.
Line 271: 
Line 272:     def sendReply(self):
Line 273:         if len(self._requests) > 0:
Line 274:             return


-- 
To view, visit https://gerrit.ovirt.org/45615
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib15cca4659553b320babf928b603a0a75013ba99
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: Yes