Dan Kenigsberg has submitted this change and it was merged.
Change subject: v2v: Log detailed output of virt-v2v
......................................................................
v2v: Log detailed output of virt-v2v
The detailed log of virt-v2v output is often necessary to debug
conversion failures. We provide '-v -x' arguments to virt-v2v to get the
detailed output and store the logs in the VDSM log directory.
We cannot use execCmd() to store the log output. Therefore we use CPopen
directly to redirect stderr to stdout and pipe it to tee to store
everything in a log file.
Logs older than 30 days are removed periodically on the daily basis.
Change-Id: I6a8d9284316a551edeaffdd66dfcd299fa02478e
Bug-Url:
https://bugzilla.redhat.com/1350465
Signed-off-by: Tomáš Golembiovský <tgolembi(a)redhat.com>
Reviewed-on:
https://gerrit.ovirt.org/59834
Reviewed-by: Francesco Romani <fromani(a)redhat.com>
Continuous-Integration: Jenkins CI
---
M lib/vdsm/v2v.py
M tests/fake-virt-v2v
A tests/fake-virt-v2v.err
M tests/fake-virt-v2v.out
M tests/v2vTests.py
M vdsm.spec.in
M vdsm/Makefile.am
M vdsm/vdsm-logrotate
8 files changed, 116 insertions(+), 45 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Francesco Romani: Looks good to me, approved
Tomas Golembiovsky: Verified
--
To view, visit
https://gerrit.ovirt.org/59834
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6a8d9284316a551edeaffdd66dfcd299fa02478e
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky <tgolembi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tomas Golembiovsky <tgolembi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>