Nir Soffer has posted comments on this change.
Change subject: vm: Require format attribute for drives
......................................................................
Patch Set 1:
Turns out that Federico has this patch
http://gerrit.ovirt.org/24202 which should fix the
root cause of this error, so we don't need this patch for debugging this issue.
More then that, Federico suggest that using the image format from __init__ is not good
enough, and we must always check the format using the disk meta data, so requiring the
format from in __init__ is not what we want.
So the proper solution will:
1. Initialize format to None if not set in __init__
2. In prepareVolumePath, use getVolumeInfo to get the real format, and update disk format,
logging a warning if the previous format was different
3. In vm.Vm._getUnderlyingDriveInfo, we will get the format from libvirt, and update drive
format, logging a warning if the format was different
--
To view, visit
http://gerrit.ovirt.org/24234
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I01ab1e071ecb76f383cc6dc7d99782e10cc90136
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Meital Bourvine <mbourvin(a)redhat.com>
Gerrit-Reviewer: Meital bourvine <meitalbourvine(a)gmail.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No