Nir Soffer has posted comments on this change.
Change subject: utils: add CommandStream class
......................................................................
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/33909/4/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 362: for fd in self._iocb:
Line 363: self._poll.register(fd, select.EPOLLIN)
Line 364:
Line 365: def _poll_input(self, fileno):
Line 366: self._iocb[fileno](os.read(fileno, io.DEFAULT_BUFFER_SIZE))
If you have signal handlers that potentially take a long time to
execute yo
It seems that fd spuriously reported as ready is an issue only with
select and no such issue is documented for poll or epoll, so this usage should be safe.
Since we don't need currently to stop watching a running command, it is good enough to
terminate the command.
Line 367:
Line 368: def _poll_event(self, fileno):
Line 369: self._poll.unregister(fileno)
Line 370: del self._iocb[fileno]
--
To view, visit
https://gerrit.ovirt.org/33909
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie015368bb9c5992e5c73a149277c59fc4ffbd570
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes