Dan Kenigsberg has posted comments on this change.
Change subject: Added Gluster file system management support.
......................................................................
Patch Set 6: (2 inline comments)
seems fine, though I suppose this should depend on
http://gerrit.ovirt.org/2797 ?
....................................................
File vdsm/BindingXMLRPC.py
Line 891: ## Gluster verbs throw errors as exception, which is retrieved
you've defined VdsmException - I wouldn't mind if EVERY VdsmException has a
response() method. That would simplify this except clause - I think you could drop all
gluster references from here...
....................................................
File vdsm/gluster/gluster_api.py
Line 221: if types.MethodType == type(func) and \
I have a deja vu ;-)
again, I prefer decorators
--
To view, visit
http://gerrit.ovirt.org/2808
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd51bec292991f7abdcacf3ba747c9662f660f51
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>