Saggi Mizrahi has posted comments on this change.
Change subject: Don't go through lvm for volume size if lv is active
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File vdsm/storage/blockVolume.py
Line 60:
It will get thrown up? I don't see why I should care?
The getLV() function can fail as well?
Line 87:
Should is a name of a fish. The reality is it isn't. VMs keep calling refresh before
checking the size (which is perfectly acceptable IMHO). Anyway, there is no reason not do
this. The less we use lvm the better.
--
To view, visit
http://gerrit.ovirt.org/677
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e81bf563f07119a775888d6abc3c81f4f7b86a0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>