Dan Kenigsberg has posted comments on this change.
Change subject: vm payload: add file injection to vm
......................................................................
Patch Set 22: (3 inline comments)
using constants.P_VDSM_RUN is a hard requirement. the rest can wait for a later patch if
you add a #TODO comment.
....................................................
File vdsm/mkimage.py
Line 32: PAYLOAD_IMAGES_P = '/var/run/vdsm/payload/'
this must be based on
constants.P_VDSM_RUN
or else we cannot move to /run when we decide to.
Line 63: os.makedirs(PAYLOAD_IMAGES_P)
check-and-later-create ad directory is raceful. Better have this created in the rpm.spec
file
Line 64: path = os.path.join(PAYLOAD_IMAGES_P, vmId + '.img')
please consider adding a hash of the "files" to the path, to allow multiple
payloads per Vm.
--
To view, visit
http://gerrit.ovirt.org/2321
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I256475342c79690a95ad999335522f99714cdc8b
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>