Nir Soffer has posted comments on this change.
Change subject: multipath: Move all calls to multipath exe to a single method
......................................................................
Patch Set 10: Code-Review+1
(1 comment)
Dan, if you want to take, I don't have a problem to rebase and change one line in
http://gerrit.ovirt.org/27242.
http://gerrit.ovirt.org/#/c/19255/10/vdsm/storage/multipath.py
File vdsm/storage/multipath.py:
Line 93: "/lib/udev/scsi_id", # Ubuntu
Line 94: )
Line 95:
Line 96:
Line 97: def _runCmd(args):
Using *args it would make be nicer to use:
_runCmd("-F")
Personally I preffer:
_runCommand("-F")
Line 98: return misc.execCmd([constants.EXT_MULTIPATH] + args, sudo=True)
Line 99:
Line 100:
Line 101: def rescan():
--
To view, visit
http://gerrit.ovirt.org/19255
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I52afc07a07a925ed7572eb369deb7c203edb04cd
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes