Saggi Mizrahi has posted comments on this change.
Change subject: [WIP]change startup process for vdsm and supervdsm start vdsm process
with supervdsmServer.py, use vdsm.init to respwan supervdsmServer. supervdsm will
terminate when vdsm crashes. If supervdsm crashes, vdsm can only do tasks which
doesn't need conne
......................................................................
Patch Set 3: I would prefer that you didn't submit this
Having a physical socket is redundant when you fork from the same root process. You should
use a pipe.
Also, having supervdsm as the main file is not recommended as supervdsm is a tool and not
the main file.
As I see it.
vdsm.py:
createPipes()
forkAndStartsvdsm(pipes)
setCreds()
startRegualVdsm()
In each of the processes:
If the pipe breaks on either side exit
Sorry if being too vague
--
To view, visit
http://gerrit.ovirt.org/4145
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I69aae6b0b9529c80291d90c6ad14ff82b21aea53
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Wenyi Gao <wenyi(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Xu He Jie <xuhj(a)linux.vnet.ibm.com>