Amit Aviram has posted comments on this change.
Change subject: vm.py: State saving in hotunplugDisk.
......................................................................
Patch Set 8: -Verified
(2 comments)
https://gerrit.ovirt.org/#/c/45077/8/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 2631: return response.error('hotunplugDisk', e.message)
Line 2632: else:
Line 2633: self._devices[hwclass.DISK].remove(drive)
Line 2634:
Line 2635: # Find and remove disk device from vm's conf
this is almost identical to _lookupConfByPath (used into the live
merge pat
This patch is only about moving code around, I don't think this change
should be in that patch. It is a good idea to add it in a following one though.
Line 2636: for dev in self.conf['devices'][:]:
Line 2637: if (dev['type'] == hwclass.DISK and
Line 2638: dev['path'] == drive.path):
Line 2639: with self._confLock:
Line 2634:
Line 2635: # Find and remove disk device from vm's conf
Line 2636: for dev in self.conf['devices'][:]:
Line 2637: if (dev['type'] == hwclass.DISK and
Line 2638: dev['path'] == drive.path):
Please fix pep8 error:
Done
Line 2639: with self._confLock:
Line 2640: self.conf['devices'].remove(dev)
Line 2641: break
Line 2642:
--
To view, visit
https://gerrit.ovirt.org/45077
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2cf18186cbba33d7e74fd15651ffec3149c98e1d
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: Yes