Dan Kenigsberg has posted comments on this change.
Change subject: rest-api: Add the basic server infrastructure
......................................................................
Patch Set 5: (2 inline comments)
....................................................
File vdsm/rest/Dispatcher.py
Line 2: # All rights reserved.
IANAL, but I think there's any problem with a BSD file in Vdsm. GPL infects it
anyway.
But don't you own your tweaks for it? shouldn't you state it, too?
oh, and there's whitespace noise.
Line 54: This is the default, built-in dispatcher for CherryPy.
don't you want to change the docstring? it slightly lies...
--
To view, visit
http://gerrit.ovirt.org/2021
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8b914f7ad82fee8d9e7e3ce6847ffe4cda374a56
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>