Eduardo has posted comments on this change.
Change subject: Avoid hsm image deletions.
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm/storage/fileSD.py
Line 512: self.log.debug("Unmounting stale file system %s",
Line 513: self.mountpoint)
Line 514: mount.getMountFromTarget(self.mountpoint).umount()
Line 515: raise se.FileStorageDomainStaleNFSHandle()
Line 516: raise
This method is dangerous, redundant since repeats the implementation of the logic for
partially deleted images and was an ad-hoc fix for issues in the removed Image.delete().
Partially deleted images do not affect other image operations any more. Only they take
space.
For clean up we should call xxSD.getRemnants()
Starting clean-ups automatically or as a side effect of other operation may be undesirable
sometimes, like an SPM failing during a long operation. Will be better if the new SPM
resumes the operation instead of remove the partials.(*)
This is unrelated to this patch.
Disclaimer: This is not related with Tasks.
Line 517:
Line 518: def templateRelink(self, imgUUID, volUUID):
Line 519: """
Line 520: Relink all hardlinks of the template 'volUUID' in all VMs based
on it.
--
To view, visit
http://gerrit.ovirt.org/17193
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1ec2ea8793a4ad63453559bc5f663b65f9b9336
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Elad Ben Aharon <eladba1990(a)gmail.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server