Change in vdsm[master]: multipath: Configure iscsi_session recovery_tmo
Nir Soffer has posted comments on this change.
Change subject: multipath: Configure iscsi_session recovery_tmo
......................................................................
Patch Set 3: Verified-1
The root cause of this issue is the 120 seconds timeout in
/etc/iscsi/iscsid.conf.
multipath try to fix this by changing session recovery_tmo
dynamically for multipath devices. They implement this when a
device is added, but do not handle the case where a device
become failed and then active again.
The udev rule added here does handle devies changes and keep the
session recovery_tmo correct.
But there is one hole - when restarting iscsid, it overwrites
recovery_tmo with the value from iscsi database (/var/lib/iscsi/nodes).
There seems to be no udev event when this happens.
So it seems that the only way to fix this reliably is to change
the default replacement_tmo in /etc/iscsi/iscsid.conf.
This requires another vdsm-tool configure module, with the normal
issues of validating configuration on startup and handling user
changes.
--
To view, visit http://gerrit.ovirt.org/32582
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaaa40fa5e6dc86beef501ef4aaefa17c4c1574c1
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No