Federico Simoncelli has posted comments on this change.
Change subject: BZ#770834 - Handle correctly nic names like p33p1
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File vdsm/configNetwork.py
Line 133: nics_rexp = re.compile("^([A-Za-z]+)([0-9]+)$")
Given your fix (anchors) consider "p33p1" and "p331":
echo -e "ifcfg-p33p1\nifcfg-p331" \
| sed -e '/ifcfg-[A-Za-z0-9#\._-]\+$/ { s/^ifcfg-//g;s/[0-9]/ &/}' | sort
-k 1,1 -k 2n
p 33p1
p 331
print nicSort(["p33p1", "p331"])
['p331', 'p33p1']
The order is different.
--
To view, visit
http://gerrit.ovirt.org/799
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I716f5d7d137325abaa0022a40f482c9ad270855a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>