Dan Kenigsberg has posted comments on this change.
Change subject: HostStats: stop storing list of host ifids and speeds
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/29470/1/vdsm/virt/sampling.py
File vdsm/virt/sampling.py:
Line 261:
Line 262: :param pid: The PID of this vdsm host.
Line 263: :type pid: int
Line 264: """
Line 265: TimedSample.__init__(self)
In a future unrelated patch, I'd really like to make use of new
style class
Ack.
Line 266: self.interfaces = dict(
Line 267: (link.name, InterfaceSample(link)) for link in getLinks())
Line 268: self.pidcpu = PidCpuSample(pid)
Line 269: self.totcpu = TotalCpuSample()
--
To view, visit
http://gerrit.ovirt.org/29470
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad0605c910564a8a7072484301c51b4b8a325751
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes