Bala.FA has posted comments on this change.
Change subject: gluster: Added geo-replication status and status detail
......................................................................
Patch Set 15:
(2 comments)
http://gerrit.ovirt.org/#/c/18414/15//COMMIT_MSG
Commit Message:
Line 1: Parent: f40345d8 (sampling: extract SampleWindow class)
Please refer
http://gerrit.ovirt.org/#/c/17766/ for comments. They are applicable in this
patch too.
I feel that this patch needs to be depend on
http://gerrit.ovirt.org/#/c/17766/
Line 2: Author: ndarshan <dnarayan(a)redhat.com>
Line 3: AuthorDate: 2013-08-22 16:08:17 +0530
Line 4: Commit: ndarshan <dnarayan(a)redhat.com>
Line 5: CommitDate: 2015-01-16 14:00:06 +0530
Line 15: remote-volumes or between a specified local and remote volume.
Line 16: Returns:
Line 17: {volumeName: 'volume name',
Line 18: sessions: [{sessionSlave: 'session slave/uuid of session',
Line 19: pairs: [{masterNode: 'master node',
could you over all change master/slave as local/remote? I feel master/local needs to be
removed and denotes as brick/volume/host etc
Line 20: masterNodeUuid: 'uuid of brick host',
Line 21: masterBrick: 'master brick',
Line 22: slave: 'slave',
Line 23: status: 'status',
--
To view, visit
http://gerrit.ovirt.org/18414
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f37f35a5480fbe049a67758e122d4a0c2eba513
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N <dnarayan(a)redhat.com>
Gerrit-Reviewer: Aravinda VK <avishwan(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com>
Gerrit-Reviewer: Darshan N <dnarayan(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes