Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: fd leak
......................................................................
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/45615/2/lib/yajsonrpc/__init__.py
File lib/yajsonrpc/__init__.py:
Line 244: "]")
Line 245:
Line 246:
Line 247: class _JsonRpcServeRequestContext(object):
Line 248: def __init__(self, client, addr):
For another patch - looking in the code, client seems to be an
instance of
This class is used from both ends. I agree that it is confusing but it
can be server or client depending on current usage.
Line 249: self._requests = []
Line 250: self._client = client
Line 251: self._addr = addr
Line 252: self._counter = 0
https://gerrit.ovirt.org/#/c/45615/2/lib/yajsonrpc/stompreactor.py
File lib/yajsonrpc/stompreactor.py:
Line 281: def is_closed(self):
Line 282: return not self._dispatcher.connected
Line 283:
Line 284: def unsubscribe(self, sub):
Line 285: pass
Is this related?
This is something that I noticed not related
to the fix. I will split it.
Line 286:
Line 287:
Line 288: class StompServer(object):
Line 289: log = logging.getLogger("yajsonrpc.StompServer")
--
To view, visit
https://gerrit.ovirt.org/45615
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib15cca4659553b320babf928b603a0a75013ba99
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: Yes