Change in vdsm[master]: sampling: use constants for counter bounds

Antoni Segura Puimedon has posted comments on this change.

Change subject: sampling: use constants for counter bounds
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

There's only minor nit but I can most assuredly live with it.

http://gerrit.ovirt.org/#/c/24194/1/vdsm/sampling.py
File vdsm/sampling.py:

Line 42: if not os.path.exists(_THP_STATE_PATH):
Line 43:     _THP_STATE_PATH =
'/sys/kernel/mm/redhat_transparent_hugepage/enabled'
Line 44: 
Line 45: JIFFIES_BOUND = 2 ** 32
Line 46: NETSTATS_BOUND = 2 ** 32
If they are not expected to differ, I'd rather have:
JIFFIES_BOUND = NETSTATS_BOUND = 2**32
Line 47: 
Line 48: 
Line 49: class InterfaceSample:
Line 50:     """


-- 
To view, visit http://gerrit.ovirt.org/24194
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I706000106c3bc31edf8541c980bce1f49464ebf8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes