Change in vdsm[master]: vm: Automatically add a serial port for a console device

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: vm: Automatically add a serial port for a console device
......................................................................

Patch Set 4:

(1 comment)

http://gerrit.ovirt.org/#/c/25979/4/vdsm/vm.py
File vdsm/vm.py:

Line 1170:         commandLine.appendChildWithArgs('qemu:arg', value='-usbdevice')
Line 1171:         commandLine.appendChildWithArgs('qemu:arg', value='keyboard')
Line 1172:         self.dom.appendChild(commandLine)
Line 1173: 
Line 1174:     def appendSerial(self):
> I tried to, but it will fail as it expects only one element :(

Let's try to use a more specific name: appendConsoleSerial (so we know that this is only for the console).
Line 1175:         """
Line 1176:         Add a serial port for the console device if it exists.
Line 1177: 
Line 1178:         <serial type='pty'>