Dan Kenigsberg has posted comments on this change.
Change subject: Implement Popen without forking back to python
......................................................................
Patch Set 11: I would prefer that you didn't submit this
(1 inline comment)
please warn (commit message, vdsm-devel) that you'd now need python-devel and gcc just
to test vdsm. And detail your reasons, some people are bound to be annoyed by this.
....................................................
File tests/betterPopenTests.py
Line 28: print p.stderr.read()
intentional? what's the intention?
--
To view, visit
http://gerrit.ovirt.org/3944
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief4ae42eb57551d7f5893bf562da451a9c98f219
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>