Change in vdsm[master]: api: use the new devel_warn helper

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: api: use the new devel_warn helper
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.ovirt.org/#/c/62210/2/lib/api/vdsmapi.py
File lib/api/vdsmapi.py:

Line 44
Line 45
Line 46
Line 47
Line 48
We use developer warnings only in this module, so better localize the solution here.

We can create the devel logger:

    _devel = logging.getLogger("devel")


Line 172:     def _report_inconsistency(self, message):
Line 173:         if self._strict_mode:
Line 174:             raise JsonRpcInvalidParamsError(message)
Line 175:         else:
Line 176:             devel_warn(message)
We can use the _devel logger here:

    _devel.warning(message)
Line 177: 
Line 178:     def verify_args(self, rep, args):
Line 179:         try:
Line 180:             # check whether there are extra parameters


-- 
To view, visit https://gerrit.ovirt.org/62210
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idc85dde59e09a5882e9d586fb0d37d2434f0a351
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: Yes