Igor Lvovsky has submitted this change and it was merged.
Change subject: Change storageServer to handle numeric connection values
......................................................................
Change storageServer to handle numeric connection values
engine is sending the connection information as a map of
string keys and string values. VDSM tries to parse version,retrans and
timeout as numbers, but due to the nature of the passed map
it receives a string containing numerical values for these arguments, and
fails.
This patch performs cast to int of the numercial values, and in case of
failure, throws an exception indicating which value raised the exception
Change-Id: I4d1716a6f66a108d60f39fad14d92625a692d0e3
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M vdsm/storage/storageServer.py
1 file changed, 10 insertions(+), 3 deletions(-)
Approvals:
Ayal Baron: Looks good to me, approved
Dan Kenigsberg: Looks good to me, but someone else must approve
Igor Lvovsky:
Yair Zaslavsky: Verified
--
To view, visit
http://gerrit.ovirt.org/5062
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4d1716a6f66a108d60f39fad14d92625a692d0e3
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>