Francesco Romani has posted comments on this change.
Change subject: Live Merge: Extend internal block volumes during merge
......................................................................
Patch Set 10:
(1 comment)
http://gerrit.ovirt.org/#/c/31268/10/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 5512:
Line 5513: return {'status': doneCode}
Line 5514:
Line 5515: def _diskXMLGetVolumeChainInfo(self, diskXML, drive):
Line 5516: def find_element_by_name(doc, name):
consistency with the remainder of the module suggests
findElementByName, bu
Sorry, got confused, this will apply to the parent patch.
However, future work anyway.
Line 5517: for child in doc.childNodes:
Line 5518: if child.nodeName == name:
Line 5519: return child
Line 5520: return None
--
To view, visit
http://gerrit.ovirt.org/31268
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3a9e0ebdb9c42df713c40e0fc5782945eb7228a8
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes