Darshan N has posted comments on this change.
Change subject: gluster: geo-replication configuration related verbs.
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/30162/3/vdsm/gluster/cli.py
File vdsm/gluster/cli.py:
Line 1132: def _parseVolumeGeoRepConfigList(tree):
Line 1133: """
Line 1134: Returns:
Line 1135: {geoRepConfig:[{'option name': name of the configuration,
Line 1136: 'description': value of the configuration}]
Shouldn't this key be optionValue?
Done
Line 1137: }
Line 1138: """
Line 1139: result = {}
Line 1140: conf = tree.find('geoRep/config')
--
To view, visit
http://gerrit.ovirt.org/30162
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifee571dbf3c56633e415d32f8d518cb64aaf1add
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N <dnarayan(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes