Change in vdsm[master]: fix circular reference of storage pool

Royce Lv has posted comments on this change.

Change subject: fix circular reference of storage pool
......................................................................

Patch Set 2:

Hi Saggi,
   I'm sorry I can't understand what do you mean by "could't it be solved by weakref?".
   1.If you mean this is not a problem because we have storage domain weakref cache.I think it's not true,you can check bug 806774 and reproduce it by checking storage pool refcount after storagepool create.circular reference means storage pool's partial function refers to itself.the sdc won't help this problem.
   2.If you mean using weakref in the partial function to solve this problem, I guess this may look wired write in that way.and we need to do a lot of extra changes,I think it maybe the clearest way to fix this.

please check sp.py(__init__) and bug 806774 for details of this patch.Thanks for your review.Would you please explain us more detailly?

--
To view, visit http://gerrit.ovirt.org/3242
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2993b0ad8d85898ca86008f7056973ff493e8de
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Saggi Mizrahi