Adam Litke has posted comments on this change.
Change subject: Related to 846307 - Simplifying clientIF._cleanOldFiles().
......................................................................
Patch Set 6: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/clientIF.py
Line 466:
Line 467: if fileExt in known_exts and vmId not in self.vmContainer:
Line 468: fPath = os.path.join(constants.P_VDSM_RUN, fName)
Line 469: try:
Line 470: utils.rmFile(constants.P_VDSM_RUN + fName)
you just calculated fPath above. Why not use it here instead of '+'?
Line 471: except OSError:
--
To view, visit
http://gerrit.ovirt.org/8626
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd63a1f4b1c64f84d5734da033a2420b97ce0ada
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>