Dan Kenigsberg has posted comments on this change.
Change subject: Related to 846307 - Simplifying clientIF._cleanOldFiles().
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(2 inline comments)
thanks for the bravery of touch this old sh*t. few comments.
....................................................
File vdsm/clientIF.py
Line 452: self.log.debug("Error recovering VM", exc_info=True)
Line 453: return None
Line 454:
Line 455: def _cleanOldFiles(self):
Line 456: known_exts = ("guest.socket", "monitor.socket",
"pid", "stdio.dump",
"monitor.socket" and "stdio.dump" are from el5 days. Long deceased.
Line 457: "recovery")
Line 458: dontDel = ("vdsmd.pid", "respawn.pid",
"svdsm.pid", "svdsm.sock")
Line 459:
Line 460: fNames = [fName for fName in os.listdir(constants.P_VDSM_RUN)
Line 454:
Line 455: def _cleanOldFiles(self):
Line 456: known_exts = ("guest.socket", "monitor.socket",
"pid", "stdio.dump",
Line 457: "recovery")
Line 458: dontDel = ("vdsmd.pid", "respawn.pid",
"svdsm.pid", "svdsm.sock")
set()s would be nicer.
Line 459:
Line 460: fNames = [fName for fName in os.listdir(constants.P_VDSM_RUN)
Line 461: if fName not in dontDel]
Line 462: for fName in fNames:
--
To view, visit
http://gerrit.ovirt.org/8626
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd63a1f4b1c64f84d5734da033a2420b97ce0ada
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>