Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: [REVIEW ONLY] Added Gluster file system management support.
......................................................................
Patch Set 2: (5 inline comments)
....................................................
File vdsm/BindingXMLRPC.py
Line 898: except ge.GlusterException, e:
I'm still not happy about this because it will break if gluster is not available. I
know it's an annoying problem and still unsure what the best solution is. Something
like a base exception class that can be extended might be the best choice.
....................................................
File vdsm/gluster/gluster_cli.py
Line 82: volumeOptions[tokens[0].strip()] = tokens[1].strip()
I think creating a variable for tokens[0].strip().upper() might be useful here.
Line 93: volumeInfo["replicaCount"] = m.groups()[1]
Equal to m.group(2)
Line 100: volumeInfo["stripeCount"] = m.groups()[1]
Equal to m.group(2)
....................................................
File vdsm/gluster/gluster_exception.py
Line 42: self.err = err if err else []
How about:
self.x = x or []
--
To view, visit
http://gerrit.ovirt.org/2808
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd51bec292991f7abdcacf3ba747c9662f660f51
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>