Igor Lvovsky has posted comments on this change.
Change subject: remove stale libvirtNet before creating a new net with same name
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm/configNetwork.py
Line 662: removeLibvirtNetwork(network, log=False)
Dan, correct me if I am wrong, but
if you want to overwrite defined libvirt network here it maybe too late.
Look at _addNetworkValidation in addNetwork.
You have there:
if bridge in _netinfo.networks:
raise ConfigNetworkError(ne.ERR_USED_BRIDGE,
"Bridge already exists")
When _netinfo.networks you take from libvirt.
It means you will fail here before you reach createLibvirtNetwork().
Am I missing something?
Line 676: logging.debug('failed to remove libvirt network ' +
netName,
c'mon man, what about %s ?
--
To view, visit
http://gerrit.ovirt.org/4370
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c25064ece089b0b5cdbad3c8789ec964c7b8752
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Avi Tal <atal(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>