Change in vdsm[master]: [RFC] operation: Support streaming command output
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: [RFC] operation: Support streaming command output
......................................................................
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/75008/3/lib/vdsm/storage/operation.py
File lib/vdsm/storage/operation.py:
Line 78: out, err = self._proc.communicate()
Line 79: self._finalize(out, err)
Line 80: return out
Line 81:
Line 82: def irun(self):
itr_run is more appropriate name
Line 83: """
Line 84: Run a command, iterating on data received from underlying command
Line 85: stdout.
Line 86:
Line 89:
Line 90: Raises:
Line 91: `RuntimeError` if invoked more then once
Line 92: `exception.ActionStopped` if the command was aborted
Line 93: `cmdutils.Error` if the command failed
those are not raised from this func .. underline implementation might require changes in
this comment. isn't that a recipe for wrong comments? I see you're doing that in
more func docs
Line 94: """
Line 95: self._start_process()
Line 96: err = bytearray()
Line 97: for src, data in procutils.communicate(self._proc):
--
To view, visit https://gerrit.ovirt.org/75008
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I976314ce3e9a1b4ba77d74c3c1ad742cc0e9fe80
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes