Change in vdsm[master]: Added VDSM interface for the virt-alignment-scan tool from l...

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Added VDSM interface for the virt-alignment-scan tool from libguestfs
......................................................................


Patch Set 9: I would prefer that you didn't submit this

(3 inline comments)

Thanks Sasha for your other shot. I'd understand it if you prefer that some else takes
this from here (though you are more than welcome to go on!). lemme know.

....................................................
File tests/alignmentScan_test.py
Line 22: import unittest
let's make use of the new nose framework.

this file has to be pep8 compliant in order to pas make check-local.

Line 28: class RunScanArgsTestCase(unittest.TestCase):
since this functionality is currently optional, I think the test should be skipped if
virt-align-scan is not installed.

....................................................
File vdsm/alignmentScan.py
Line 39:     #if not os.path.exists(image_path):
no need for dead code, pep8

--
To view, visit http://gerrit.ovirt.org/2916
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d2c146a0fa3101317720f2e9c373e0d21b5cfdf
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saša Tomić <tomic80(a)gmail.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl&gt;
Gerrit-Reviewer: Saša Tomić <tomic80(a)gmail.com&gt;