Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: fd leak
......................................................................
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/45615/2/lib/yajsonrpc/__init__.py
File lib/yajsonrpc/__init__.py:
Line 244: "]")
Line 245:
Line 246:
Line 247: class _JsonRpcServeRequestContext(object):
Line 248: def __init__(self, client, addr):
I guess we need to find a better name and add documentation
explaining what
Done
Line 249: self._requests = []
Line 250: self._client = client
Line 251: self._addr = addr
Line 252: self._counter = 0
--
To view, visit
https://gerrit.ovirt.org/45615
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib15cca4659553b320babf928b603a0a75013ba99
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: Yes