Change in vdsm[master]: BZ#732980 MD tag must be in blocks unit

Saggi Mizrahi has posted comments on this change.

Change subject: BZ#732980 MD tag must be in blocks unit
......................................................................


Patch Set 3: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File vdsm/storage/blockSD.py
Line 575:             freeSlot, freeSlotRem = divmod(SD_METADATA_SIZE, blkSize)
you can do divmod(SD_METADATA_SIZE + (blkSize -1), blkSize) and always get good results

....................................................
File vdsm/storage/lvm.py
Line 940:         return None
This flow will happen if the VG was not found, throw this error and don't just return
None

--
To view, visit http://gerrit.usersys.redhat.com/891
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id268735f60a289f9e8f12a7d7bb3180bf3398c54
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;