Ondřej Svoboda has posted comments on this change.
Change subject: netinfo: Retrieve bonding options differing from defaults
......................................................................
Patch Set 10:
(1 comment)
http://gerrit.ovirt.org/#/c/24456/10/tests/functional/networkTests.py
File tests/functional/networkTests.py:
Line 1162: self.assertBondExists(BONDING_NAME, bondDict['nics'])
Line 1163:
Line 1164: # See if live options (read from sysfs) match those requested
Line 1165: cfg = self.vdsm_net.netinfo.bondings[BONDING_NAME]['cfg']
Line 1166: self.assertEqual(cfg['BONDING_OPTS'],
bondDict['options'])
As you said,
Okay, it's not much of an advantage that we
know our bondopts are sorted.
Line 1167:
Line 1168: with dummyIf(3) as nics:
Line 1169: with self.vdsm_net.pinger():
Line 1170: # Add initial vlanned net over bond
--
To view, visit
http://gerrit.ovirt.org/24456
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes